Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make watchers instant #1145

Merged
merged 4 commits into from
Nov 9, 2022
Merged

make watchers instant #1145

merged 4 commits into from
Nov 9, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Nov 9, 2022 •
edited
Loading

  • Makes watchers called immediately if the are synchronous.
  • Added _rich_traceback_omit=True to a few places, so that the internals between setting an attribute and an exception in the watch method are not visible

@willmcgugan willmcgugan requested review from darrenburns and davep and removed request for darrenburns November 9, 2022 12:16
@willmcgugan willmcgugan merged commit 51d5e7d into main Nov 9, 2022
@willmcgugan willmcgugan deleted the instant-watchers branch November 9, 2022 14:51
@davep davep mentioned this pull request Nov 14, 2022
Closed
@JoshKarpel JoshKarpel mentioned this pull request Nov 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willmcgugan @darrenburns